Re-seed image if needed

[3DTOPO]

If the total loss from previous iteration is 0, the image is re-seeded, otherwise a "function value changing less than tolX" message will appear and fail.

Moved the image initialization code into a reusable function and called if the total loss from previous iteration is 0 at proposed line 301.

Tested with many images and has worked every time. Note that you are more likely to reproduce the issue the larger the image output size is. Try 1024-1568.

[spencermize]

I can confirm this fixes my issues with "function value changing less than tolX".

[3DTOPO]

Nice, glad to hear it. I can report that I have over 1,000 high res renders done with it now (non-stop). No added memory leaks as far as I can tell.

[spencermize]

After a few runs, I'm starting to run into some coloring issues after receiving the re-seeding message. See the attached - small image (no re-seed) looks "correct" whereas the big (re-seeded) image looks off. This has happened on every re-seeded photo, I think.

Thoughts?

[3DTOPO]

I could be wrong but I think its because you are rendering it at a different scale. What do they look like the same scale and if re-seeded?

[spencermize]

I've only managed to get it to re-seed on large resolution outputs. I've
come close (1750px runs don't seem to error) and the scale looks okay. The
one I attached isn't massively larger (2250px) but the colors and stylings
are very far off.
On Dec 21, 2015 9:13 PM, "Jeshua Lacock" [email protected] wrote:

I could be wrong but I think its because you are rendering it at a
different scale. What do they look like the same scale and if re-seeded?

—
Reply to this email directly or view it on GitHub
#97 (comment)
.

[3DTOPO]

I guess I am not sure what I am looking at. You attached a really large render and a quite small one.

[spencermize]

Sorry - I'm struggling to find my 1750px render. I'll try to re-run and
repost.
On Dec 21, 2015 9:32 PM, "Jeshua Lacock" [email protected] wrote:

I guess I am not sure what I am looking at. You attached a really large
render and a quite small one.

—
Reply to this email directly or view it on GitHub
#97 (comment)
.

[spencermize]

I did a few more runs while adjusting the scale - definitely better. Thanks
for the tip!
On Dec 21, 2015 9:32 PM, "Jeshua Lacock" [email protected] wrote:

I guess I am not sure what I am looking at. You attached a really large
render and a quite small one.

—
Reply to this email directly or view it on GitHub
#97 (comment)
.

[dionysio]

Thanks for this PR! I could not for the life of me figure out why it was crashing randomly for some images and this fixed it.

[0wnrepo]

@spencermize you might also want to look at this : #171

[tenorslowworm]

Thanks, @3DTOPO, your fix is working great for me!