Added an optional message terminator option for read methods. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @CetinOzdil thanks for putting this together! I will take a look. Re: my comment on your other PR, this one could make it much easier for someone to build their own framing - e.g. "read until you receive \r\n\r\n" or something similar. |
|
@jchristn This would eliminate a lot of code for me- how are things looking? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Actually this pull request is somehow linked to my previous pull request. In short if we send a request to a device and expect for example 25 bytes long response but instead we receive 13 bytes response to complete read TcpClient will wait until timeout. But some devices (like the one i am working with now) have fixed message termination sequences (like { 0x03, 0x02 } or line feed etc. ) So to eleminate extra wait I added an option to read methods to search received data for message termination sequence and if found finalize reading and resize stream according to sequence position.