Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation #31

Open
jchartrand opened this issue Jan 18, 2012 · 11 comments
Open

validation #31

jchartrand opened this issue Jan 18, 2012 · 11 comments
Assignees

Comments

@jchartrand
Copy link
Owner

Add a validation button that sends the text to the validation service, and displays the results in a popup. Later we'll consider displaying the error in some more 'permanent' part of the editor display, like a collapsible panel over the right, or at the bottom.

Validation should also be triggered just before a save. If valid, go ahead with the save. If invalid show errors, but still give the end user the option to save anyhow.

The validation service is described here:

http://research.artsrn.ualberta.ca/cwrcxml/

The URLs for the Orlando events schema are:

cwrc.ca/schema/events ( I think you just pass this one which references the next. the validator should I think retrieve and merge the referenced schema)
cwrc.ca/schema/common

The URL for the CWRC TEI schema:

http://www.cwrc.ca/schema/cwrcbasic

So, what remains to be done I think is simply to send the right schema url to the validator on validation. i.e, the cwrcbasic when someone is editing a cwrcbasic doc and the orlando events when they're editing an orlando events doc.

@ghost ghost assigned ajmacdonald Jan 18, 2012
@jchartrand
Copy link
Owner Author

I've amended the issue to:

  1. confirm that the error should be displayed in a popup
  2. the end user should be allowed to save an invalid document

@ajmacdonald
Copy link
Collaborator

We'll need to setup a proxy service for this since the validation URL is on a different server.

@jchartrand
Copy link
Owner Author

http://apps.testing.cwrc.ca/services/validator/

On 2012-01-24, at 4:58 PM, ajmacdonald wrote:

We'll need to setup a proxy service for this since the validation URL is on a different server.


Reply to this email directly or view it on GitHub:
#31 (comment)

@ajmacdonald
Copy link
Collaborator

Thanks! What schema should I be specifying?

@jchartrand
Copy link
Owner Author

Hi Andrew,

I thought the links for the events and common schema that I pasted in the original issue description worked, but now they don't seem to. Have you been able to access them?

james

On 2012-01-25, at 12:11 PM, ajmacdonald wrote:

Thanks! What schema should I be specifying?


Reply to this email directly or view it on GitHub:
#31 (comment)

@ajmacdonald
Copy link
Collaborator

Ah I missed that. They're down for me too.

@jchartrand
Copy link
Owner Author

I cleared my browser cache and they now work.

On 2012-01-25, at 2:15 PM, ajmacdonald wrote:

Ah I missed that. They're down for me too.


Reply to this email directly or view it on GitHub:
#31 (comment)

@ajmacdonald
Copy link
Collaborator

Common works, but not event.

@jchartrand
Copy link
Owner Author

They're both working for me after clearing the cache. Do they work in another browser? In any case, I think they can be passed along to the validator, and we'll see if it chokes on them?

On 2012-01-25, at 3:18 PM, ajmacdonald wrote:

Common works, but not event.


Reply to this email directly or view it on GitHub:
#31 (comment)

@ajmacdonald
Copy link
Collaborator

I'll add a select box to settings to pick the schema.

@jchartrand
Copy link
Owner Author

Perfect.

On 2012-01-25, at 3:32 PM, ajmacdonald wrote:

I'll add a select box to settings to pick the schema.


Reply to this email directly or view it on GitHub:
#31 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants