Default to doing DNS resolution through a proxy server if present. #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socks
library), so users getting proxy information from an environment variable (HTTP_PROXY
/HTTPS_PROXY
) with no external DNS could not connect to hosts with DNS names. There isn't any way to setproxy_rdns
fromproxy_info_from_environment
orproxy_info_from_url
, so this gives a sensible default, makinghttplib2
work the same way as most web browsers.ProxyInfo
class.