Adds route naming to improve usability. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
force-pushed
the
adds_router_naming
branch
from
0c38e90 to
3260277
Compare
| { | ||
| $routeName = $request->request->get('_route'); | ||
|
|
||
| if (array_key_exists($routeName, $this->routes)) { |
There was a problem hiding this comment.
fyi in brave we default to "get not_found" or "get redirected" when we are in a framework that supports routes, but there was no route found.
There was a problem hiding this comment.
This is not the same case. If $routeName is null then we return a not_found. If $routeName != null and it is not in the routes then there is something wrong and we fail gracefully.
jcchavezs
force-pushed
the
adds_router_naming
branch
from
3260277 to
106d903
Compare
jcchavezs
commented
Feb 23, 2018
src/ZipkinBundle/Middleware.php
Outdated
| @@ -60,7 +69,7 @@ public function onKernelRequest(GetResponseEvent $event) | |||
|
|
|||
| $span = $this->tracing->getTracer()->nextSpan($spanContext); | |||
| $span->start(); | |||
| $span->setName($request->getMethod()); | |||
| $span->setName($this->spanNaming->getName($request)); | |||
There was a problem hiding this comment.
This should run terminate.
jcchavezs
force-pushed
the
adds_router_naming
branch
from
106d903 to
a2b006f
Compare
jcchavezs
force-pushed
the
adds_router_naming
branch
from
a2b006f to
59f1bcb
Compare
|
The intent of not_found or redirected (in span name) is that someone
crawling or DOS attack wont fill up span namespace. And you can easily
search for this by name. So maybe a test of what happens when you get 404
is helpful.
|
|
@adriancole sure, https://github.com/jcchavezs/zipkin-symfony/pull/6/files#diff-759dcfcf030a5d11ef05f571c336e998R16 covers the case where the request does not match any route. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use the route path as span name without injecting the
routeras it degrades significantly the performance.For more info read https://github.com/jcchavezs/zipkin-symfony/pull/6/files#diff-04c6e90faac2675aa89e2176d2eec7d8R144