-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we should set truststore's path and pwd to maven project properties. As we do with keystore. #8
Comments
pull req is available #9 |
@wentwog bug reporting and bug fixing are two separate activities :) You report a bug, but someone else will fix it. This is how we work. Keep this in mind for the future. In general, don't work on anything unless you're explicitly being told by our project manager. Let's make this ticket an exception and assign it to you. But in the future, don't rush. |
waiting #10 |
Sounds good, but can you clarify: it I, while fixing a bug, found its cause and know how to fix it, then likely it's better if I fix the cause too rather then other guy would spend some time on investigation, I've already have done. But, maybe this is wrong, so I'd be pleased to hear you comment on this. |
I see your logic, but this is against one of our key principle: we keep knowledge in the source code, not in our heads. If you find a bug and you fix it, the knowledge about it will stay in your head. When/if you leave the project, future developers will have to spend time again, to find out how you fixed the issue. If you report a bug and someone else is fixing it - the history of the problem is more traceable, in discussions, in source code, etc. Make sense? |
Yes, makes, but if I create the 2nd bug, the bug for the cause of the 1st bug, and refer from the 1st bug to the 2nd one - wouldn't we have the traceability, you've mentioned ? |
Maybe, but we have a general rule - bugs shouldn't be fixed by their reporters. We never violate this rule, well, unless something exceptional happens. So, please follow it :) |
@alevohin it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done |
@wentwog thank you for reporting this, I added 15 mins to your acc, transaction |
@wentwog if you think that the problem is solved, close the issue. You're the reporter, so you have to close it. Regarding the time, we don't do it like this. The budget is fixed and we don't extend it. Since you're just starting, we'll make an exception. In the future, keep in mind that all tasks are fixed-cost and never increase their budgets. |
@rultor release, tag is |
@rultor release, tag is |
If we don't then the truststore created upon the plugin execution will not be used if we initialize our truststore as described here.
And this method of truststore initialization is the one we use in tests, for example.
This issue need to be fixed in order for other issue be fixed
The text was updated successfully, but these errors were encountered: