Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should set truststore's path and pwd to maven project properties. As we do with keystore. #8

Closed
wentwog opened this issue Dec 28, 2014 · 23 comments

Comments

@wentwog
Copy link
Contributor

wentwog commented Dec 28, 2014

If we don't then the truststore created upon the plugin execution will not be used if we initialize our truststore as described here.

And this method of truststore initialization is the one we use in tests, for example.

This issue need to be fixed in order for other issue be fixed

@wentwog
Copy link
Contributor Author

wentwog commented Dec 28, 2014

pull req is available #9

@yegor256
Copy link
Member

@wentwog bug reporting and bug fixing are two separate activities :) You report a bug, but someone else will fix it. This is how we work. Keep this in mind for the future. In general, don't work on anything unless you're explicitly being told by our project manager. Let's make this ticket an exception and assign it to you. But in the future, don't rush.

@yegor256
Copy link
Member

@dmarkov please assign @wentwog to this problem

@wentwog
Copy link
Contributor Author

wentwog commented Dec 28, 2014

waiting #10

@wentwog
Copy link
Contributor Author

wentwog commented Dec 28, 2014

@yegor256

You report a bug, but someone else will fix it.

Sounds good, but can you clarify: it I, while fixing a bug, found its cause and know how to fix it, then likely it's better if I fix the cause too rather then other guy would spend some time on investigation, I've already have done.

But, maybe this is wrong, so I'd be pleased to hear you comment on this.

@yegor256
Copy link
Member

I see your logic, but this is against one of our key principle: we keep knowledge in the source code, not in our heads. If you find a bug and you fix it, the knowledge about it will stay in your head. When/if you leave the project, future developers will have to spend time again, to find out how you fixed the issue. If you report a bug and someone else is fixing it - the history of the problem is more traceable, in discussions, in source code, etc. Make sense?

@wentwog
Copy link
Contributor Author

wentwog commented Dec 28, 2014

Yes, makes, but if I create the 2nd bug, the bug for the cause of the 1st bug, and refer from the 1st bug to the 2nd one - wouldn't we have the traceability, you've mentioned ?

@yegor256
Copy link
Member

Maybe, but we have a general rule - bugs shouldn't be fixed by their reporters. We never violate this rule, well, unless something exceptional happens. So, please follow it :)

@dmarkov
Copy link

dmarkov commented Dec 31, 2014

@alevohin it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket

The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

@wentwog
Copy link
Contributor Author

wentwog commented Dec 31, 2014

@dmarkov, so this task is no longer my ? Why ? It just waits #10 to be fixed.
This current task itself is finished until then, as I see it.

@dmarkov
Copy link

dmarkov commented Dec 31, 2014

@dmarkov please assign @wentwog to this problem

@yegor256 done, @wentwog is a new assignment at the task, please go on. whoever worked with this task before, please stop right now

@dmarkov
Copy link

dmarkov commented Jan 1, 2015

@wentwog thank you for reporting this, I added 15 mins to your acc, transaction 49704922

@wentwog
Copy link
Contributor Author

wentwog commented Jan 7, 2015

@dmarkov PL is merged.
Can I have additional 30m in this task since additional time have been required to implemented unit test we had discussed with @yegor256.

@yegor256
Copy link
Member

yegor256 commented Jan 7, 2015

@wentwog if you think that the problem is solved, close the issue. You're the reporter, so you have to close it. Regarding the time, we don't do it like this. The budget is fixed and we don't extend it. Since you're just starting, we'll make an exception. In the future, keep in mind that all tasks are fixed-cost and never increase their budgets.

@yegor256
Copy link
Member

yegor256 commented Jan 7, 2015

@dmarkov please add extra 30 mins to @wentwog

@yegor256
Copy link
Member

yegor256 commented Jan 7, 2015

@rultor release, tag is 0.10

@rultor
Copy link
Contributor

rultor commented Jan 7, 2015

@rultor release, tag is 0.10

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jan 7, 2015

@rultor release, tag is 0.10

@yegor256 Oops, I failed. You can see the full log here (spent 9min)

yegor256 pushed a commit that referenced this issue Jan 7, 2015
@yegor256
Copy link
Member

yegor256 commented Jan 7, 2015

@rultor release, tag is 0.10

@rultor
Copy link
Contributor

rultor commented Jan 7, 2015

@rultor release, tag is 0.10

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jan 7, 2015

@rultor release, tag is 0.10

@yegor256 Done! FYI, the full log is here (took me 8min)

@dmarkov
Copy link

dmarkov commented Jan 8, 2015

@dmarkov please add extra 30 mins to @wentwog

@yegor256 I've sent 30 mins extra to @wentwog in transaction ID "49978477"

@dmarkov
Copy link

dmarkov commented Jan 14, 2015

@wentwog Much obliged! I've added 30 mins to your account in payment "50259067". +30 added to your rating, current score is: +65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants