Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestResponsePactOps needs support for passing a scala Map to .given() #38

Closed
solarmosaic-kflorence opened this issue Jul 29, 2021 · 3 comments

Comments

@solarmosaic-kflorence
Copy link

When specifying a provider state with .given(), the second argument can be a Map of parameters. We should add support for using a scala Map there like we have for .headers.

@jbwheatley
Copy link
Owner

fixed in 0.0.13

@solarmosaic-kflorence
Copy link
Author

@jbwheatley looks like this is still missing on PactDslWithProvider (which is the case if it's applied as the very first statement). For example:

ConsumerPactBuilder
  .consumer(consumerName)
  .hasPactWith(providerName)
  .given("greeting", Map("name" -> "world"))

Seems to be working in other cases though (I tested PactDslResponse specifically)

@solarmosaic-kflorence
Copy link
Author

^ the above was fixed in 0.0.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants