Merge pull request #7 from jbowes/filecache-mkdir

teach filecache to make its dir

impl/file.go

@@ -8,6 +8,7 @@ import (
 	"context"
 	"encoding/json"
 	"os"
+	"path/filepath"
 )
 
 // FileCacher is the default Cacher used in whatsnew.
@@ -31,6 +32,10 @@ func (f *FileCacher) Get(context.Context) (*Info, error) {
 
 // Set cached release Info.
 func (f *FileCacher) Set(_ context.Context, i *Info) error {
+	if err := os.MkdirAll(filepath.Dir(f.Path), 0750); err != nil {
+		return err
+	}
+
 	w, err := os.Create(f.Path)
 	if err != nil {
 		return err

impl/file_test.go

@@ -57,3 +57,35 @@ func TestFileCacher_roundTrip(t *testing.T) {
 	}
 
 }
+
+func TestFileCacher_errOnWrite(t *testing.T) {
+	ctx := context.Background()
+
+	fc := impl.FileCacher{Path: filepath.Join("/", "test-cache.json")}
+
+	err := fc.Set(ctx, &impl.Info{
+		CheckTime: time.Now(),
+		Version:   "v1.1.2",
+		Etag:      `"some-etag"`,
+	})
+
+	if err == nil {
+		t.Errorf("expected err but go none")
+	}
+}
+
+func TestFileCacher_errOnMkDir(t *testing.T) {
+	ctx := context.Background()
+
+	fc := impl.FileCacher{Path: filepath.Join("/", "whatsnew-test", "test-cache.json")}
+
+	err := fc.Set(ctx, &impl.Info{
+		CheckTime: time.Now(),
+		Version:   "v1.1.2",
+		Etag:      `"some-etag"`,
+	})
+
+	if err == nil {
+		t.Errorf("expected err but go none")
+	}
+}