-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBWS-4430]:Sever throws IllegalStateException when call a handler wi… #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @jimma , when this will be ready (in general, not just wrt my other comments here), please be sure to include a testcase to cover this new scenario. Thanks!
modules/server/src/main/java/org/jboss/wsf/stack/cxf/interceptor/HandlerAuthInterceptor.java
Outdated
Show resolved
Hide resolved
modules/server/src/main/java/org/jboss/wsf/stack/cxf/interceptor/HandlerAuthInterceptor.java
Outdated
Show resolved
Hide resolved
Yes. That is on my todo list. |
…th the CDI bean invocation
…s to access CDI bean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jim, this looks ok, I've added a couple of minor comments.
WRT the AbstractTCCLPhaseInterceptor, I'm wondering if you explored the possibility of configuring that automatically by interjecting the creation of the interceptor chain in a modified PhaseInterceptorChain which could decide to wrap configured interceptors. Just a thought though, I haven't really verified / tested anything ;-)
modules/server/src/main/java/org/jboss/wsf/stack/cxf/interceptor/HandlerAuthInterceptor.java
Outdated
Show resolved
Hide resolved
modules/server/src/main/java/org/jboss/wsf/stack/cxf/interceptor/HandlerAuthInterceptor.java
Outdated
Show resolved
Hide resolved
@asoldano Yes. I tried with checking the classloader and by adding set TCCL with interceptor.getClass().getClassLoader() in PhaseInterceptorChain for each interceptor before the interceptor call, but this will slows down the performance. The current approach is more efficient as we need to set TCCL only for the interceptor which has CDI access. |
…;Improve comment and test
@asoldano I rename the |
…th the CDI bean invocation