Avoid capturing ACC when not necessary #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1859,7 +1861,7 @@ void completeTermination() { | |||
| waiters = waiters.getNext(); | |||
| } | |||
| tail.setNext(TERMINATE_COMPLETE); | |||
| if (! DISABLE_MBEAN) { | |||
There was a problem hiding this comment.
native-image can no longer DCE this path, which can result in failures due to JMX now being reachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can avoid capturing the AccessControlContext when MBeans are disabled.
The
accfield is holding a reference to the classloader, which is leading us to have a classloader leak in Quarkus during some integration tests - in some cases it leads to critical failures as we exhaust memory on CI.There might be better ways to avoid the CL leak in Quarkus but this seems easy enough and useful anyway?