Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jboss-public repository #216

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Remove jboss-public repository #216

merged 1 commit into from
Oct 16, 2023

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Oct 16, 2023

Fixes #117

@dmlloyd
Copy link
Member Author

dmlloyd commented Oct 16, 2023

A bit of history on this: I believe the JBoss repo was added by me in f6be08b in order to support MR JARs, which at the time required a patch to the maven-compiler-plugin which upstream would not accept. They have since started supporting MR JARs though, and we've since moved to the upstream version of the compiler plugin. Thus, this bit no longer does anything useful, and sometimes actually causes issues.

@dmlloyd
Copy link
Member Author

dmlloyd commented Oct 16, 2023

See jboss-remoting/jboss-marshalling#124

@dmlloyd dmlloyd merged commit 577ca41 into jboss:main Oct 16, 2023
1 check passed
@dmlloyd dmlloyd deleted the release branch October 16, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove jboss-public repository by default
2 participants
@dmlloyd @jamezp