Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wildfly-maven-plugin to CI #176

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add wildfly-maven-plugin to CI #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,16 @@ jobs:
mvn -B -ntp versions:update-parent -DallowSnapshots=true -N
git diff pom.xml
mvn -B -ntp install -Djava8.home=${{env.JAVA_HOME_8_X64}} -Djava11.home=${{env.JAVA_HOME_11_X64}}

- name: Check out WildFly Maven Plugin
uses: actions/checkout@v2
with:
repository: wildfly/wildfly-maven-plugin
path: wildfly-maven-plugin

- name: Test WildFly Maven Plugin with updated parent
run: |
cd wildfly-maven-plugin
mvn -B -ntp versions:update-parent -DallowSnapshots=true -N
git diff pom.xml
mvn -B -ntp install -Djava8.home=${{env.JAVA_HOME_8_X64}} -Djava11.home=${{env.JAVA_HOME_11_X64}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work? The wildfly-maven-plugin requires Java 11 and uses the org.wildfly.tools:wildfly-parent https://github.com/wildfly/wildfly-maven-plugin/blob/61bfbe9dd704afe92ad07e686e3425f45ec88085/pom.xml#L27-L31.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, specifying a java8.home doesn't cause the profile to run; it only runs if the control file is present. The idea is that if we cut & paste the entry for other projects, we don't lose anything.

That said, we've since dropped Java 8 support from the POM in #207 so we could drop the install action for Java 8 and these properties without any side-effect.

Loading