[LOGMGR-314] SocketHandlerTests produce BindException: Address already in use

[kstekovi]

https://issues.redhat.com/browse/LOGMGR-314

[jamezp]

We might be best to just pass 0 to the port and then change the SimpleServer to return the port it used instead. Or we should use the loop to find the open port in the getPort() rather than the tests themselves.

[kstekovi]

Hi @jamezp Thank you for your advice to use 0 which will use the free port automatically. This is great for most test is this TC. But unfortunately this approach cannot be used for testProtocolChange and testTcpReconnect because one handler and two servers are used in the test. When is created second server for test it must use same port as the first server in the test. So I added sleep to give OS some extra time to release port used by the first server and avoid java.net.BindException: Address already in use

the SocketHandler cannot be created with 0 as ServerSocket and exact port must be specified. With 0 it produce IllegalStateException: An address and port greater than 0 is required.

[kstekovi]

Hi @jamezp could you please take a look?

[jamezp]

Is this needed? It feels like a guess at best TBH and feels fragile.

[kstekovi]

I think too this should not be here. But I didn't find way how to safely verify a port is free. All ways which i found are similar to:

try (Socket ignored = new Socket("localhost", port)) {
        return false;
    } catch (ConnectException e) {
        return true;
    }

And we don't have guarantees after end of try with resources or after close method is a port really free. Sometimes isn't - especially when the CPU is utilized to 100% and these tests are started.

[jamezp]

Upstream #377