-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding marker property to ExLogRecord #335
Conversation
This new property will be used to propagate the Marker to the actual logging library. Since both SLF4J and Log4j define a different Marker class without any common interface, here an Object is used.
@jamezp as mentioned in dmlloyd/jboss-logmanager-embedded#3, adding Please have a look! |
It's going to maybe be a bit before I can look at this and think it through completely. However for the integration I think we'll need to use some kind of reflection. |
It's a pity that we don't have a In terms of reflection, I think it would be important to do the check up front (i.e. during static initialization) and set a static final boolean field. We may then be able to call the method directly, as long as we bracket it in an |
Yes agreed we should definitely check during static initialization. It definitely would be nice to invoke the method directly. I don't see why that wouldn't work at least. |
tentative implementation here: jboss-logging/slf4j-jboss-logmanager@2391fc2 @jamezp @dmlloyd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me.
@dfa1 Sorry for the delay. I don't see an issue with this really. The only real reason I haven't merged it is because we don't really use master anywhere currently. |
Clicked comment too soon :) I want to look at maybe backporting this as well to the 2.2 branch. It seems it could be useful there as well. |
@jamezp no worries... and thank you for moving this forward! |
This new property will be used to propagate the Marker to the actual
logging library. Since both SLF4J and Log4j define a different Marker
class without any common interface, here an Object is used.