Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOGMGR-161] Make best attempt to only calculate caller information i… #129

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Jul 28, 2017

…f the formatter being used requires it.

https://issues.jboss.org/browse/LOGMGR-161

@jamezp
Copy link
Member Author

jamezp commented Jul 28, 2017

@dmlloyd Would you mind giving this a review to make sure I'm not overlooking anything?

/**
* A formatter which uses a text pattern to format messages.
*/
public class PatternFormatter extends MultistepFormatter {
private static final Pattern CALLER_CHECK_PATTERN = Pattern.compile(".*(%M|%C|%F|%L|%l).*");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern will miss items that have field widths, won't it? I think you might want to just query the format steps directly instead maybe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. We may just have to add something to the FormatStep. Since we're using Java 8 now though that shouldn't be an issue.

@jamezp jamezp merged commit bbb9d22 into jboss-logging:master Aug 9, 2017
@jamezp jamezp deleted the LOGMGR-161 branch August 10, 2017 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants