[Backport] Property refactoring #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
squakez
commented
Jun 9, 2021
squakez
commented
- chore(e2e): config test (chore(e2e): config test apache/camel-k#2295)
- feat(cmd): build-property flag (feat(cmd): build-property flag apache/camel-k#2309)
- feat(cmd/run): property configuration refactoring (feat(cmd/run): property configuration refactoring apache/camel-k#2329)
- feat(cmd/run): --config option flag (feat(cmd/run): --config option flag apache/camel-k#2339)
* Changed Java test with Groovy test * Covered all resources cases (base encoded) Ref apache#2003
* Added configmap and secret integration tests * Refactored to be included and run under /common dir Ref apache#2003
* The operator panicked because some equality on slices. * Checking if the kit has no traits which was always having the comparison succesful
* Included a build-time-properties in Builder trait to provide the Build task the ability to add build time properties. * Introduced a new flag which will allow the user to introduce build time properties. It will convert into build-time-properties, as expected by the Builder trait.
* Deprecating --property-file flag in favour of --property file: format. Ref apache#2003
* Introducing --config [configmap|secret|file]:name * Deprecate --configmap and --secret Ref apache#2003
The old config flag is clashing with the new one that we want to introduce for run subcommand. It makes sense to rename it as --kube-config as it makes reference to kube configuration file. Ref apache#2003
Introduced a new list of flags that accept multiple values. If they are passed a file: syntax, the value will be expanded with the relative file location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.