Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPENJDK-1130] revert accidental commits to rhel7 images #329

Merged
merged 6 commits into from
Nov 3, 2022

Conversation

jmtd
Copy link
Member

@jmtd jmtd commented Nov 1, 2022

https://issues.redhat.com/projects/OPENJDK/issues/OPENJDK-1130

These commits were made on what was the "develop" branch intended for the ubi8 images, but we forked the rhel7 branch afterwards.

@jmtd jmtd requested a review from jerboaa November 1, 2022 20:44
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. These checksum failures for prometheus-jmx-agent need investigating:

  features/image/prometheus.feature:33  Ensure the Prometheus Agent JAR has the expected checksum
  File "/home/runner/cekit4.3.0/lib/python3.6/site-packages/cekit/builder.py", line 27, in execute

@jmtd
Copy link
Member Author

jmtd commented Nov 3, 2022

The md5 hash in the unit test is correct for the artefact we ship in RHEL7 :

-- md5: 8b3af39995b113baf35e53468bad7aae
-  target: jmx_prometheus_javaagent-0.3.2.redhat-00003.jar

I've just confirmed a scratch build with the new pnc stuff pulled in the right artefacts.

But the hash is not correct for UBI8 since we updated prometheus-jmx-exporter-0.12.0-8.el8_6.noarch
(it is now 1a9b7eb478c72028ca91e1bf6e40b48f).

So,

  1. this is further evidence we should just turn off GHA for the rhel7 branch IMHO
  2. we need to update the hash - but in the ubi8 branch, not here

@jmtd jmtd merged commit 84ee6f6 into jboss-container-images:rhel7 Nov 3, 2022
@jmtd jmtd deleted the rhel7-revert-accidental branch November 3, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants