This repository has been archived by the owner on Nov 21, 2022. It is now read-only.
Move Activity Start from IOutgoingLogicalMessageContext to IOutgoingPhysicalMessageContext #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icalMessageContext) to allow customization. Resolves jbogard#9 on-behalf-of: @Phreesia <[email protected]
jbogard
reviewed
Feb 9, 2022
| _activityEnricher = activityEnricher; | ||
| } | ||
|
|
||
| public override async Task Invoke(IOutgoingPhysicalMessageContext context, Func<Task> next) | ||
| { | ||
| using (var activity = StartActivity(context)) | ||
| var activity = Activity.Current; |
There was a problem hiding this comment.
I think this is OK but one thing I found in other places is you can't necessarily assume Activity.Current is there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the outgoing message activity start in the message pipeline from from
IOutgoingLogicalMessageContexttoIOutgoingPhysicalMessageContext. This change allows theActivityobject to encompass a larger scope and allows it to be enriched from an implementation ofIMutateOutgoingTransportMessages(resolves #9).