Resolves issue with unexpected InvalidOperationExceptions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This PR resolves issue #30.
The problem is that
DiagnosticsActivityEventSubscriberwants to return previously captured current activity toActivity.Currentproperty again. In theActivity.Currentsetter there is a check that fails when the activity is stopped. When the "parent" activity is stopped in the meanwhile, exception is thrown.The same code raises the exception also when you call a sync version of a mongo command. In this case, command's activity is the same as the
Activity.Currentactivity. Insideaction(), activity gets stopped, and afterwards activity is again assigned toActivity.Currentproperty.Both issues should be fixed by this PR.
Thanks.