Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes to be compliant with OpenTelemetry #25

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Update attributes to be compliant with OpenTelemetry #25

merged 1 commit into from
Feb 14, 2024

Conversation

joegoldman2
Copy link
Contributor

@joegoldman2 joegoldman2 commented Feb 13, 2024

Update few attributes to match the spec (https://opentelemetry.io/docs/specs/semconv/database/database-spans/ and https://opentelemetry.io/docs/specs/semconv/database/mongodb/):

  • Rename net.transport to network.transport
  • Update value of network.transport from ip_tcp to tcp
  • Rename net.sock.peer.addr to network.peer.address (in case EndPoint is IPEndPoint)
  • Rename net.peer.port to network.peer.port (in case EndPoint is IPEndPoint)
  • Rename net.peer.name to server.address (in case EndPoint is DnsEndPoint)
  • Rename net.peer.port to server.port (in case EndPoint is DnsEndPoint)

@jbogard jbogard merged commit 65a037e into jbogard:master Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants