Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying newer instanbul #37

Closed
wants to merge 1 commit into from
Closed

trying newer instanbul #37

wants to merge 1 commit into from

Conversation

dmill-bz
Copy link
Collaborator

Temp PR just to check build and coverage. You can ignore for now.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.3%) to 95.833% when pulling f343d9c on coverals-maps-fix into ef9d2ed on master.

@dmill-bz
Copy link
Collaborator Author

Ok, so basically this PR updates istanbul. What comes from this is that before this PR the coverage was done on the lib/* files. This is 1) giving an incorrect result and 2) means you can't get file reports in coveralls.

This PR fixes this and uses src/* files correctly. Though the file reports seem very minimal, it seems to only tell you which methods are being checked? see here : https://coveralls.io/builds/5500079/source?filename=src%2FGremlinClient.js

I don't know if this is a normal level of coverage report from istanbul/JS or if I'm still getting something wrong.
Coming from php our file reports tell us how many times each line is executes which is pretty different. For instance, it's obvious that I haven't tested the case of a close() on an open transaction.
image
I was hoping istanbul would provide something similar. hmmm

@dmill-bz
Copy link
Collaborator Author

Actually I'm pretty sure It's not working right yet. Lets put this on hold

@dmill-bz
Copy link
Collaborator Author

dmill-bz commented Apr 3, 2016

FYI I got this working on gremlin-console with karma and browser tests. So I'll change this PR to include that configuration if you're cool with it.

@jbmusso
Copy link
Owner

jbmusso commented Apr 3, 2016

Ah that's cool! Sure, go ahead. Thanks.

@dmill-bz
Copy link
Collaborator Author

dmill-bz commented Apr 7, 2016

Closing this in favor of PR#45

@dmill-bz dmill-bz closed this Apr 7, 2016
@dmill-bz dmill-bz deleted the coverals-maps-fix branch April 7, 2016 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants