Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS review suggestions #57

Merged
merged 11 commits into from
Nov 28, 2019
Merged

JOSS review suggestions #57

merged 11 commits into from
Nov 28, 2019

Conversation

afrubin
Copy link
Contributor

@afrubin afrubin commented Nov 28, 2019

This PR contains several relatively small suggested edits for the paper and documentation.

@afrubin afrubin mentioned this pull request Nov 28, 2019
Closed
38 tasks
jbloom
jbloom reviewed Nov 28, 2019
View reviewed changes
Copy link
Member

@jbloom jbloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look like good changes to me, thanks @afrubin!

@khdusenbury, I would say approve and merge these if they seem correct to you. I don't think we need to increment version number as none of them change the code itself.

khdcrawford
khdcrawford approved these changes Nov 28, 2019
View reviewed changes
Copy link
Collaborator

@khdcrawford khdcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afrubin for the edits! They all look good to me. I'll merge the request.

@khdcrawford khdcrawford merged commit 26efecd into jbloomlab:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbloom jbloom jbloom left review comments

@khdcrawford khdcrawford khdcrawford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afrubin @jbloom @khdcrawford