Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A minimum tactical fix for issue #697 #698

Merged
merged 6 commits into from
Oct 15, 2020

Conversation

SteveGilham
Copy link
Contributor

Terminate the iteration if it steps on to a null Instruction to allow for uninitialized trailing cells in the case of size less than capacity.

@jbevain
Copy link
Owner

jbevain commented Oct 14, 2020

Hello @SteveGilham,

Thank for the PR! Could add a unit test to the test suite from your repro before I merge? Thanks!

Jb

(cherry picked from commit 185ba88)
@SteveGilham
Copy link
Contributor Author

The test does a little more manipulation than the plain "it blows up" repro to

  1. match the full use case in which the issue arose
  2. get to an end state that is simple to assert

I don't know if there's a more elegant way in the infrastructure to get at the assembly -- the code in the module tests to load an assembly and do tests seemed to do more than required by way of repeating all symbol reading combinations.

@jbevain jbevain merged commit 77f7bd1 into jbevain:master Oct 15, 2020
@jbevain
Copy link
Owner

jbevain commented Oct 15, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants