2024 12 13 int test cleanup #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbesraa
force-pushed
the
2024-12-13-int-test-cleanup
branch
2 times, most recently
from
1f80f31 to
0a81c0e
Compare
jbesraa
force-pushed
the
2024-12-13-int-test-cleanup
branch
from
0a81c0e to
1a1a43d
Compare
jbesraa
force-pushed
the
2024-12-13-int-test-cleanup
branch
3 times, most recently
from
9b3ce59 to
1814d1d
Compare
functions return signature
jbesraa
force-pushed
the
2024-12-13-int-test-cleanup
branch
3 times, most recently
from
1cefc7c to
e55db1d
Compare
it's important to have a descriptive name for when this is published to crates.io
into the following modules: - lib: with general purpose functions (e.g.: starters) - sniffer - template_provider
this struct is redundant and no other roles follow this pattern we can do the initialization inside `start_pool`
the `SocketAddr` is not a client, but the socket where we will listen to also, `listner` is a typo
the original naming was confusing copypasta
..to hold utility functions used internaly only.
jbesraa
force-pushed
the
2024-12-13-int-test-cleanup
branch
from
e55db1d to
d7e6f3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.