-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding/Updating Spanish Translations #1042
base: master
Are you sure you want to change the base?
Conversation
Thanks for that; it's always good to improve the user experience in their own language. A request and a question:
|
Oh lord. I'm so incredibly sorry for the reverts. By the time I realized my reverts were being committed, it was too late. If you couldn't tell, this is my first time doing any of this. I'd be more than happy to have this request closed and I'll open a new one with just the one commit for the strings.xml file. Good to know about the build! I took the source from the master branch and didn't modify any of the files other than the strings file, and it didn't build on my end or on the test. The second commit was an attempt to fix some of the dependency issues it spat back at me. To answer your second question: probably yes! I'm not a native speaker, but I've got 5 years of high school Spanish under my belt. I have absolutely no doubt that there's a large difference in vocabulary for each region. However, I couldn't even begin to differentiate that out myself. I think the app should certainly be usable for most Spanish speakers though as it is. The vocabulary that may differ between countries likely only makes up 1-2% of the text in the application. I'll take a look into it though to see if there's anything I can find that could be improved! |
@ElijahMSmith you don't need to make a new PR for the actual translations, you can just adjust this one. To start with, you can get rid of the reversions by going to your local repo and doing And then If you have changes that aren't translations, you can make those in a separate branch, and make a new PR from that. |
Added many translations of string that were previously not given a Spanish translation.
Updated numerous translations with English words not translated or incorrect grammar/vocabulary.