Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenNIC domains to extended TLDs. #15

Merged
merged 3 commits into from
May 14, 2020
Merged

Conversation

matyapiro31
Copy link
Contributor

OpenNIC domain list is from:
https://en.wikipedia.org/wiki/OpenNIC
OpenNIC domains are non-ICANN TLDs and large free DNS project.

OpenNIC domain list is from:
https://en.wikipedia.org/wiki/OpenNIC
OpenNIC domains are non-ICANN TLDs and large free DNS project.
@matyapiro31
Copy link
Contributor Author

@Stebalien Please check this.

Copy link
Contributor

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the list and it matches https://wiki.opennic.org/opennic/dot 👍

@matyapiro31 is there a reason to not also add the peered TLDs?
https://wiki.opennic.org/opennic/dot?redirect=1#peered_top-level_domains

1. add organization to comments.
2. fix conflict.
@matyapiro31
Copy link
Contributor Author

I trust OpenNIC, but I don't know much of peered TLDs.
If someone want to add them, I don't hate it.

@lidel
Copy link
Contributor

lidel commented May 14, 2020

@matyapiro31 fair enough. I think we can merge this as-is then.

I miss permissions, so pinging @Stebalien / @Kubuxu

@Kubuxu Kubuxu merged commit d541499 into jbenet:master May 14, 2020
@lidel
Copy link
Contributor

lidel commented May 14, 2020

@Stebalien ok to make another release to with OpenNIC? I'd like us to land this in go-ipfs 0.6.

@Stebalien
Copy link
Collaborator

Done.

@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants