Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to mark http url as trusted #1698

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

ritikverma2000
Copy link
Contributor

I have added http inside trustedSource.startsWith .

image

@maxandersen
Copy link
Collaborator

The build is failing because formatting not applied and no tests added to verify this actually works.

Please run gradle spotlessApply build clean to have formatting applied and have tests pass. See CONTRIBUTING.MD for details.

Thanks.

@ritikverma2000
Copy link
Contributor Author

ritikverma2000 commented Oct 24, 2023

The build is failing because formatting not applied and no tests added to verify this actually works.

Please run gradle spotlessApply build clean to have formatting applied and have tests pass. See CONTRIBUTING.MD for details.

Thanks.

Sure @maxandersen.

Hi @maxandersen I have just now added this to handle "http" case so the testcase is passing.

image

image

@maxandersen maxandersen changed the title Fixed trustedSource issue fix: allow to mark http url as trusted Nov 19, 2023
@maxandersen
Copy link
Collaborator

Thans @ritikverma2000 I fixed the formatting so builds will work.

@maxandersen maxandersen enabled auto-merge (squash) November 19, 2023 08:09
@maxandersen maxandersen merged commit a32dea9 into jbangdev:main Nov 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants