Add test for when_all throwing on individual tasks. #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original behavior for coro::when_all was to capture the T result or an exception and then when the user iterates all of the completed tasks the task.return_value() would either return the result or re-throw the exception for that specific task.
jbaldwin
force-pushed
the
when_all_throws_test
branch
from
7b71600
to
1a72a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original behavior for coro::when_all was to capture the T result or an exception and then when the user iterates all of the completed tasks the task.return_value() would either return the result or re-throw the exception for that specific task.