Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure JReleaser #737

Closed
wants to merge 3 commits into from
Closed

Configure JReleaser #737

wants to merge 3 commits into from

Conversation

aalmiray
Copy link
Contributor

This PR configures JReleaser for creating Git releases and publishing distributions to Sdkman.
It also adds GitHub workflows for:

  • building on PRs
  • publishing early-access builds

A workflow for publishing a final release is pending.

The following enviroment variables are required

  • JRELEASER_GITHUB_TOKEN
  • JRELEASER_GPG_PASSPHRASE
  • JRELEASER_GPG_PUBLIC_KEY
  • JRELEASER_GPG_SECRET_KEY

Values for these variables may be stored at a local file in .properties, .yml, .toml, or .json format. Refer to https://jreleaser.org/guide/latest/configuration/environment.html Set these values if you intended to test releases locally. You may also set these values as repository secrets.

Refer to https://jreleaser.org/guide/latest/configuration/signing.html for how to configured GPG signing

@aalmiray aalmiray marked this pull request as draft December 24, 2021 22:11
@aalmiray
Copy link
Contributor Author

converting to draft as it requires JReleaser v0.10.0, to be released in the coming days.

@jonbullock
Copy link
Member

I'll mark this for inclusion in the 2.7.0 release.

@jonbullock jonbullock added this to the v2.7.0 milestone Dec 27, 2021
@aalmiray aalmiray marked this pull request as ready for review December 28, 2021 15:43
@aalmiray
Copy link
Contributor Author

@jonbullock ready for merge

@jonbullock jonbullock self-assigned this Jan 2, 2022
java-version: 11
distribution: 'zulu'

- uses: actions/cache@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is. Don't count on that feature to be permanent, as you may have noticed in this issue actions/setup-java#40 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reporter of actions/setup-java#40 and this is only about configuring Maven but not about caching at all (particularly not about caching Gradle artifacts)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm well aware of that which is why I typed "as you may have noticed". IMHO setup-java should be concerned with just that: setting up a suitable JDK/JRE/JR. Adding caching for Maven or any other Java build tool is beyond its scope.

Copy link
Contributor

@kwin kwin Jan 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may happen, but never in a 2.x release of setup-java (is it would be backwards-incompatible). As long as you use setup-java@v2 I would recommend getting rid of additional caching action steps and leverage what is shipped with setup-java@v2 as having additional steps

  1. makes your yml larger
  2. doesn't provide additional functionality
  3. defers builds as every step is additional overhead

@jonbullock
Copy link
Member

I'll manually merge this in now #740 has been merged in before it.

jonbullock added a commit to jonbullock/jbake that referenced this pull request Jan 3, 2022
@jonbullock jonbullock closed this Jan 5, 2022
@aalmiray aalmiray deleted the jreleaser branch January 6, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants