-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure JReleaser #737
Configure JReleaser #737
Conversation
converting to draft as it requires JReleaser v0.10.0, to be released in the coming days. |
I'll mark this for inclusion in the 2.7.0 release. |
@jonbullock ready for merge |
java-version: 11 | ||
distribution: 'zulu' | ||
|
||
- uses: actions/cache@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supported by setup-java as well: https://github.com/actions/setup-java#caching-packages-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is. Don't count on that feature to be permanent, as you may have noticed in this issue actions/setup-java#40 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am reporter of actions/setup-java#40 and this is only about configuring Maven but not about caching at all (particularly not about caching Gradle artifacts)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm well aware of that which is why I typed "as you may have noticed". IMHO setup-java
should be concerned with just that: setting up a suitable JDK/JRE/JR. Adding caching for Maven or any other Java build tool is beyond its scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may happen, but never in a 2.x release of setup-java (is it would be backwards-incompatible). As long as you use setup-java@v2 I would recommend getting rid of additional caching action steps and leverage what is shipped with setup-java@v2 as having additional steps
- makes your yml larger
- doesn't provide additional functionality
- defers builds as every step is additional overhead
I'll manually merge this in now #740 has been merged in before it. |
This PR configures JReleaser for creating Git releases and publishing distributions to Sdkman.
It also adds GitHub workflows for:
A workflow for publishing a final release is pending.
The following enviroment variables are required
Values for these variables may be stored at a local file in
.properties
,.yml
,.toml
, or.json
format. Refer to https://jreleaser.org/guide/latest/configuration/environment.html Set these values if you intended to test releases locally. You may also set these values as repository secrets.Refer to https://jreleaser.org/guide/latest/configuration/signing.html for how to configured GPG signing