Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate binary distribution publishing #422

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

ancho
Copy link
Member

@ancho ancho commented Feb 2, 2018

Automates the publication of the binary distribution to bintray.

@ancho ancho added this to the v2.6.0 milestone Feb 2, 2018
@ancho ancho requested a review from jonbullock February 2, 2018 21:08
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.875% when pulling ab96fb4 on ancho:feature/automate-binary-distribution into 5300a31 on jbake-org:master.

@coveralls
Copy link

coveralls commented Feb 2, 2018

Coverage Status

Coverage remained the same at 79.852% when pulling e61dda4 on ancho:feature/automate-binary-distribution into 27b9981 on jbake-org:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.875% when pulling ab96fb4 on ancho:feature/automate-binary-distribution into 5300a31 on jbake-org:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.875% when pulling ab96fb4 on ancho:feature/automate-binary-distribution into 5300a31 on jbake-org:master.

Copy link
Member

@jonbullock jonbullock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as a Gradle build can do! 😉

The only question I've got is whether the folder jbake-app should be jbake-dist? Since it's reason for being is to facilitate the dist from being created. It's only a question though, no need to change it, just wondered if it's convention.

@jonbullock
Copy link
Member

Can #373 be closed as I assume this supersedes it?

@ancho
Copy link
Member Author

ancho commented Mar 1, 2018

The only question I've got is whether the folder jbake-app should be jbake-dist?

Probably yes. I'll change it to jbake-dist. It's more concise.

Can #373 be closed as I assume this supersedes it?

Yes. It was just a proof of concept. We are getting there ;)
It also closes #274.

moved sources to new module jbake-core

added jbake-cli as java library used by jbake-app to bundle
distribution.

aggregate jacoco test report and configure coveralls for root project

generate aggregated test report for all subprojects

some words about jacocoRootTestReport and smoke tests

update gradle to 4.5

added build matrix and test osx too

heapspace options for gradle

drop precise and oraclejdk7 which is deprecated at travis now

run openjdk7 on precise.

removed jbake-cli module for now and merged back to jbake-core

add jdk9 build to appveyor

wrong jdk7 path. documentation https://www.appveyor.com/docs/build-environment/#java broken

increase MaxPermSize for tests

renamed jbake-app to jbake-dist
@ancho ancho force-pushed the feature/automate-binary-distribution branch from e20f523 to e61dda4 Compare March 1, 2018 22:42
@ancho ancho merged commit aac695e into jbake-org:master Mar 1, 2018
@ancho ancho mentioned this pull request Mar 1, 2018
@ancho ancho deleted the feature/automate-binary-distribution branch March 11, 2018 12:05
Mushiyo added a commit to Mushiyo/netilfy-jbake-example-project-groovy that referenced this pull request Apr 2, 2018
Updated JBake download path since JBake has changed it (jbake-org/jbake#422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants