-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support/wagtail-50 #457
Support/wagtail-50 #457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just one small change to look at.
py{311}-dj{41}-wt{41,42,50} | ||
py{311}-dj{42}-wt{50} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
py{311}-dj{41}-wt{41,42,50} | |
py{311}-dj{42}-wt{50} | |
py{311}-dj{41,42}-wt{41,42,50} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also,
Can it be:
py{38,39,310}-dj{32,40}-wt{41,42}
py{38,39,310,311}-dj{41,42}-wt{41,42,50}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we should also test Python versions 3.8-3.10 for Wagtail 5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, Django 4.2 is indeed not compatible with Wagtail 4.1 and 4.2.
Changed to:
py{38,39,310}-dj{32,40,41}-wt{41,42}
py{311}-dj{32,41}-wt{41,42,50}
py{38,39,310,311}-dj{42}-wt{50}
Please let me know if I forgot a combination or if there's a more efficient way. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @katdom13 I think we've had too much tox in our lives 😅 py311 and dj32 won't work will it? I've caused you more confusion with my initial comment. You are right that wt50 is the only version that supports dj42.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just one small change to look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @katdom13 !
Please don't forget to update the docs as well 🙏
https://github.com/jazzband/wagtailmenus/blob/master/docs/source/index.rst
(I can also do it on the weekend if you don't have the time)
Hi @MrCordeiro , Please let me know if I forgot something. |
2a524aa
to
46754f4
Compare
46754f4
to
35532f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Wagtail 5.0 release notes: https://docs.wagtail.org/en/stable/releases/5.0.html