Support for wagtail42 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This remove try/except and VERSION checks
nickmoreton
commented
Feb 9, 2023
| @@ -89,3 +87,5 @@ | |||
| # ---------- | |||
| # Deprecated | |||
| # ---------- | |||
|
|
|||
| ADD_EDITOR_OVERRIDE_STYLES = True | |||
There was a problem hiding this comment.
These styles don't seem to be needed anymore. The wagtail UI deals with them perfectly.
nickmoreton
commented
Feb 9, 2023
| @@ -17,11 +17,6 @@ class MainMenuAdmin(ModelAdmin): | |||
| edit_view_class = views.MainMenuEditView | |||
| add_to_settings_menu = True | |||
|
|
|||
| def get_form_view_extra_css(self): | |||
There was a problem hiding this comment.
These styles don't seem to be needed anymore. The wagtail UI deals with them perfectly. Also removed the second instance in this file.
Closed
|
Great work @nickmoreton. I hope the maintainers can merge this soon! |
|
I'll take a look tonight :) |
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
- Coverage 98.21% 98.12% -0.10%
==========================================
Files 89 89
Lines 3029 2929 -100
==========================================
- Hits 2975 2874 -101
- Misses 54 55 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the sites dependencies so it can be used with Wagtail versions >= 4.1
I have removed the try/except and Wagtail VERSION conditionals and code that supported older versions which I hope you agree does simply the package. I understand that may not be what you prefer and I am happy to revert those changes to keep the older versions around.
I have also adjusted the tox and github actions to help simplify the running of tests.
Issues that could be solved with other updates include:
Some UI elements were misplaced and those are also fixed.
Also the docs could do with been updated I think but I'll wait till you let me know about supporting older versions.