-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/settings panel append #441
Fix/settings panel append #441
Conversation
when running tests there are several build failures related to incompatible django/wagtail versions, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Ben sorry for the delay >︿<
I find your PR pretty complete. It's great, thanks!
The only thing I ask is for you to rebase your fork so that we get rid of merge conflicts.
If this fixes the remaining WARNINGs, I'd be glad to see this merged!
|
…o the existing settings_panel so we don't lose wagtail settings
15a2322
to
c719304
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice work, @benfroelich!
see issue 440
Changes to docs/source/contributing/index.rst are cosmetic and not related; I can revert if desired. I thought it was easier to read this way using shell expansion.