Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep/3.0.2 #369

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Release prep/3.0.2 #369

merged 5 commits into from
Jun 17, 2020

Conversation

sekanitembo
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #369 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   98.12%   98.14%   +0.01%     
==========================================
  Files          88       88              
  Lines        2828     2855      +27     
==========================================
+ Hits         2775     2802      +27     
  Misses         53       53              
Impacted Files Coverage Δ
wagtailmenus/__init__.py 76.47% <100.00%> (ø)
wagtailmenus/utils/misc.py 92.98% <100.00%> (-3.25%) ⬇️
wagtailmenus/utils/tests/test_misc.py 100.00% <100.00%> (ø)
wagtailmenus/utils/version.py 100.00% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab5931...55a723a. Read the comment docs.

Copy link
Collaborator

@ababic ababic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sekanitembo. Thank you so much for this. Really appreciate you getting involved. I usually try to separate the PRs for compatibility and releases, but this will work fine. I would like to make this an alpha release for the time being though - there might be other things that can go into 3.0.2 as well.

.travis.yml Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
docs/source/releases/3.0.2.rst Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
wagtailmenus/__init__.py Outdated Show resolved Hide resolved
wagtailmenus/utils/misc.py Outdated Show resolved Hide resolved
wagtailmenus/utils/tests/test_misc.py Outdated Show resolved Hide resolved
@ababic
Copy link
Collaborator

ababic commented Jun 17, 2020

@sekanitembo Don't sweat the codecov failure :) It's only complaining because the new code isn't run in the version that is used to generate the coverage report. I'm happy to ignore the warning and merge anyway.

@sekanitembo
Copy link
Contributor Author

@ababic Happy to help! Thanks for letting me pitch in. I made all the changes you mentioned in the review, and am happy to do what's needed to comply with your usual practice of separating compatibility/release PRs. I was just following the docs on releases, so I can add an issue for adding a compatibility PR to the docs, too, if you want.

@sekanitembo sekanitembo requested a review from ababic June 17, 2020 20:01
@ababic
Copy link
Collaborator

ababic commented Jun 17, 2020

@sekanitembo yes, that particular bit of documentation is for maintainers really (I don't expect contributors to prepare releases, or even add release notes), but I appreciate you taking the initiative. I suppose you've saved me a job really :)

@ababic ababic merged commit eab6762 into jazzband:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants