-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release prep/3.0.2 #369
Release prep/3.0.2 #369
Conversation
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
==========================================
+ Coverage 98.12% 98.14% +0.01%
==========================================
Files 88 88
Lines 2828 2855 +27
==========================================
+ Hits 2775 2802 +27
Misses 53 53
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sekanitembo. Thank you so much for this. Really appreciate you getting involved. I usually try to separate the PRs for compatibility and releases, but this will work fine. I would like to make this an alpha release for the time being though - there might be other things that can go into 3.0.2 as well.
@sekanitembo Don't sweat the codecov failure :) It's only complaining because the new code isn't run in the version that is used to generate the coverage report. I'm happy to ignore the warning and merge anyway. |
@ababic Happy to help! Thanks for letting me pitch in. I made all the changes you mentioned in the review, and am happy to do what's needed to comply with your usual practice of separating compatibility/release PRs. I was just following the docs on releases, so I can add an issue for adding a compatibility PR to the docs, too, if you want. |
@sekanitembo yes, that particular bit of documentation is for maintainers really (I don't expect contributors to prepare releases, or even add release notes), but I appreciate you taking the initiative. I suppose you've saved me a job really :) |
No description provided.