-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project release config and use Travis build stages. #398
Conversation
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=========================================
- Coverage 79.17% 79.1% -0.07%
=========================================
Files 30 30
Lines 2266 2269 +3
=========================================
+ Hits 1794 1795 +1
- Misses 472 474 +2
Continue to review full report at Codecov.
|
@hugovk @claudep To fully automate the release process it's strongly recommended to use setuptools-scm to get the version string from Git during the build process (and effectively allowing to do releases simply by creating a Git tag). That would remove the need to update Python files to bump up the version. This strategy has worked very well with many other Python projects including Jazzband projects. Just want to give you a heads-up that this will contain this change as well. |
+1 for setuptools-scm, it makes versioning and releases much easier. One important thing to note: by default it includes everything from Git in the package, making the releases bigger. If we don't want all that, we'll need to explicitly exclude/prune other files/dirs. For example: hugovk/pypistats#63 |
@hugovk I'm glad you approve! That said, from the Python packaging conceptual side speaking, the purpose of source distributions is to ship all files that developers may want to use to inspect a file, including test files etc. So while the dist files may be bigger, they would also be matching the expectation of users. |
Sure, that's fine and makes sense! It's probably only a few KB bigger anyway, just wanted to flag it up as it has surprised some people in the past :) |
Yep, much appreciated that you're raising this. |
67dccf2
to
d5b3613
Compare
- isort and flake8 config - manifest template update - tox ini extension - docs build fixes - docs content fixes
Wow, many thanks for pushing that! Packaging stuff has always been a weak point for me, so I'm glad you're taking the lead on that part. |
Refs #378.