Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project release config and use Travis build stages. #398

Merged
merged 6 commits into from
Oct 18, 2019
Merged

Add project release config and use Travis build stages. #398

merged 6 commits into from
Oct 18, 2019

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Oct 18, 2019

Refs #378.

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #398 into master will decrease coverage by 0.06%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #398      +/-   ##
=========================================
- Coverage   79.17%   79.1%   -0.07%     
=========================================
  Files          30      30              
  Lines        2266    2269       +3     
=========================================
+ Hits         1794    1795       +1     
- Misses        472     474       +2
Impacted Files Coverage Δ
src/tablib/formats/_html.py 100% <ø> (ø)
src/tablib/formats/_csv.py 100% <ø> (ø)
src/tablib/packages/dbfpy/record.py 75.71% <ø> (ø)
src/tablib/formats/_json.py 96.96% <ø> (ø)
src/tablib/formats/_rst.py 93.96% <ø> (ø)
src/tablib/formats/_df.py 76.92% <ø> (ø)
src/tablib/formats/_xlsx.py 84.09% <ø> (ø)
src/tablib/packages/dbfpy3/header.py 83.83% <ø> (ø)
src/tablib/packages/dbfpy3/dbfnew.py 97.61% <ø> (ø)
src/tablib/packages/statistics.py 80% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d02aa...12ce610. Read the comment docs.

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@jezdez
Copy link
Member Author

jezdez commented Oct 18, 2019

@hugovk @claudep To fully automate the release process it's strongly recommended to use setuptools-scm to get the version string from Git during the build process (and effectively allowing to do releases simply by creating a Git tag). That would remove the need to update Python files to bump up the version. This strategy has worked very well with many other Python projects including Jazzband projects. Just want to give you a heads-up that this will contain this change as well.

@hugovk
Copy link
Member

hugovk commented Oct 18, 2019

+1 for setuptools-scm, it makes versioning and releases much easier.

One important thing to note: by default it includes everything from Git in the package, making the releases bigger. If we don't want all that, we'll need to explicitly exclude/prune other files/dirs.

For example: hugovk/pypistats#63

@jezdez
Copy link
Member Author

jezdez commented Oct 18, 2019

@hugovk I'm glad you approve! That said, from the Python packaging conceptual side speaking, the purpose of source distributions is to ship all files that developers may want to use to inspect a file, including test files etc. So while the dist files may be bigger, they would also be matching the expectation of users.

@hugovk
Copy link
Member

hugovk commented Oct 18, 2019

Sure, that's fine and makes sense! It's probably only a few KB bigger anyway, just wanted to flag it up as it has surprised some people in the past :)

@jezdez
Copy link
Member Author

jezdez commented Oct 18, 2019

Yep, much appreciated that you're raising this.

@jezdez jezdez force-pushed the ci branch 2 times, most recently from 67dccf2 to d5b3613 Compare October 18, 2019 13:09
- isort and flake8 config
- manifest template update
- tox ini extension
- docs build fixes
- docs content fixes
@jezdez jezdez merged commit f6bf14a into master Oct 18, 2019
@jezdez jezdez deleted the ci branch October 18, 2019 13:57
@claudep
Copy link
Contributor

claudep commented Oct 18, 2019

Wow, many thanks for pushing that! Packaging stuff has always been a weak point for me, so I'm glad you're taking the lead on that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants