-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cron job for pipmaster env to GitHub actions #916
Conversation
cc4dc12
to
dbdc404
Compare
Test pip-tools against pip master every day using GitHub Actions. [skip travis]
dbdc404
to
55f2db2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @atugushev good job. I am a big fan of the GH actions myself. I left you a couple of small comments. Best Joe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, I think this is cool.
I'd style the YAML differently but that's irrelevant to the functionality as is usually the case.
Don't need a pipe for a single line [skip travis]
Codecov Report
@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 98.58% 97.93% -0.66%
==========================================
Files 35 35
Lines 2264 2176 -88
Branches 290 288 -2
==========================================
- Hits 2232 2131 -101
- Misses 21 31 +10
- Partials 11 14 +3
Continue to review full report at Codecov.
|
Thanks, @pradyunsg! |
@codingjoe thanks for reviewing this as always! I've addressed some request changes in cd5a9cb and answered to the others. |
Update job name. [skip travis]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks, @codingjoe! |
Test pip-tools against pip master every day on the latest Ubuntu and Windows using GitHub Actions.
See an example of actions on my fork: https://github.com/atugushev/pip-tools/actions
Resolves #853.