Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cron job for pipmaster env to GitHub actions #916

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Add cron job for pipmaster env to GitHub actions #916

merged 3 commits into from
Oct 9, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Oct 1, 2019 •
edited
Loading

Test pip-tools against pip master every day on the latest Ubuntu and Windows using GitHub Actions.
See an example of actions on my fork: https://github.com/atugushev/pip-tools/actions

Resolves #853.

@atugushev atugushev added the maintenance Related to maintenance processes label Oct 1, 2019
@atugushev atugushev force-pushed the gh-actions-cron branch 2 times, most recently from cc4dc12 to dbdc404 Compare October 1, 2019 22:16
@jazzband jazzband deleted a comment from codecov bot Oct 1, 2019
@atugushev
Add cron for pipmaster env to GitHub actions [skip appveyor]
55f2db2 
Test pip-tools against pip master every day using GitHub Actions.

[skip travis]
@atugushev atugushev mentioned this pull request Oct 6, 2019
Closed
codingjoe
codingjoe requested changes Oct 6, 2019
View reviewed changes
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atugushev good job. I am a big fan of the GH actions myself. I left you a couple of small comments. Best Joe

.github/workflows/cron.yml Outdated Show resolved Hide resolved
.github/workflows/cron.yml Outdated Show resolved Hide resolved
.github/workflows/cron.yml Show resolved Hide resolved
.github/workflows/cron.yml Outdated Show resolved Hide resolved
.github/workflows/cron.yml Show resolved Hide resolved
pradyunsg
pradyunsg approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, I think this is cool.

I'd style the YAML differently but that's irrelevant to the functionality as is usually the case.

@atugushev
Address review comments [skip appveyor]
cd5a9cb 
Don't need a pipe for a single line

[skip travis]
@codecov
Copy link

codecov bot commented Oct 6, 2019 •
edited
Loading

Codecov Report

Merging #916 into master will decrease coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   98.58%   97.93%   -0.66%     
==========================================
  Files          35       35              
  Lines        2264     2176      -88     
  Branches      290      288       -2     
==========================================
- Hits         2232     2131     -101     
- Misses         21       31      +10     
- Partials       11       14       +3
Impacted Files Coverage Δ
piptools/repositories/pypi.py 85.5% <0%> (-5.72%) ⬇️
tests/test_sync.py 98.74% <0%> (-1.26%) ⬇️
piptools/repositories/local.py 91.11% <0%> (-0.89%) ⬇️
tests/conftest.py 97.36% <0%> (-0.34%) ⬇️
piptools/writer.py 99.14% <0%> (-0.06%) ⬇️
piptools/scripts/sync.py 100% <0%> (ø) ⬆️
piptools/resolver.py 100% <0%> (ø) ⬆️
tests/test_writer.py 100% <0%> (ø) ⬆️
piptools/cache.py 100% <0%> (ø) ⬆️
tests/test_cli_compile.py 100% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd8aee7...9962ce3. Read the comment docs.

@atugushev
Copy link
Member Author

Thanks, @pradyunsg!

@atugushev
Copy link
Member Author

@codingjoe thanks for reviewing this as always! I've addressed some request changes in cd5a9cb and answered to the others.

@atugushev
Address review comments [skip appveyor]
9962ce3 
Update job name.

[skip travis]
codingjoe
codingjoe approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atugushev atugushev merged commit 8e782ae into jazzband:master Oct 9, 2019
@atugushev atugushev deleted the gh-actions-cron branch October 9, 2019 05:07
@atugushev
Copy link
Member Author

Thanks, @codingjoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingjoe codingjoe codingjoe approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

@blueyed blueyed Awaiting requested review from blueyed

Assignees
No one assigned
Labels
maintenance Related to maintenance processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip-compile fails with current master branch of pip
3 participants
@atugushev @codingjoe @pradyunsg