-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output all logging to stderr (#353) #834
Conversation
I would gladly merge this. @vphilippon what do you think? Should we take advantage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re base
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
- Coverage 98.76% 98.68% -0.08%
==========================================
Files 36 36
Lines 2193 2137 -56
Branches 285 279 -6
==========================================
- Hits 2166 2109 -57
Misses 16 16
- Partials 11 12 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
- Coverage 98.76% 98.68% -0.08%
==========================================
Files 36 36
Lines 2193 2137 -56
Branches 285 279 -6
==========================================
- Hits 2166 2109 -57
Misses 16 16
- Partials 11 12 +1
Continue to review full report at Codecov.
|
|
Outputs all logging stuff to stderr which fixes a number of current open issues including #353 and #275.
Note that this breaks the existing CLI. Namely, if anyone is relying on the fact that stuff comes out of standard output and redirecting it somewhere. They shouldn't be, but someone probably is.
One liner: Output all logging to stderr instead of stdout
Contributor checklist