Added command line flag "--unsafe" to allow the pinning of #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"unsafe" dependencies; unfortunately there are some valid
instances of needing to enforce this, it seems like setuptools
in particular goes through various phases of backwards
compatibility.
I wasn't 100% certain how to run the tests ("python setup.py test"
didn't seem to do the trick) but I did add a best guess at how
to test the new option.
|
|
||
| for ireq in unsafe_packages: | ||
| line = self._format_requirement(ireq, reverse_dependencies, primary_packages) | ||
| yield line |
There was a problem hiding this comment.
I like the idea for this flag. Rather than putting in an explicit comment here and repeat some of the code, I'd be fine simply setting the unsafe_packages set to the empty set (on line 62) if this flag is active. This will not make setuptools stand out from the rest (but that's the intention if this flag is used anyway).
|
To run the tests, run: |
|
Ok, updated the code to reflect your suggestions, I wasn't able to get the test for the 'unsafe' option to pass (indexing issues I think) but kind of ran out of time to look into it... |
|
Implemented in #377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"unsafe" dependencies; unfortunately there are some valid
instances of needing to enforce this, it seems like setuptools
in particular goes through various phases of backwards
compatibility.
I wasn't 100% certain how to run the tests ("python setup.py test"
didn't seem to do the trick) but I did add a best guess at how
to test the new option.