Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out origin ireqs for extra requirements before writing output annotations #2011

Merged

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Oct 27, 2023

Resolves #2003, closes #2007

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@AndydeCleyre
Copy link
Contributor

Thanks!

Minor note on terms, in the pip-tools context: "header" usually refers to the big comment at the top, while the comments this PR affects are "annotations."

@chrysle chrysle changed the title Filter out origin ireqs for extra requirements before writing output header Filter out origin ireqs for extra requirements before writing output annotations Oct 27, 2023
@chrysle
Copy link
Contributor Author

chrysle commented Oct 27, 2023

Right, I don't know what moved me to replicating the mistake ;-)

@chrysle chrysle force-pushed the requirements-header-filter-out-origin-ireqs branch from 4182dea to f6ff30b Compare October 27, 2023 18:44
@chrysle chrysle added bug Something is not working writer Related to results output writer component labels Oct 31, 2023
Comment on lines +3311 to +3312
with open(req_in, "w") as req_out:
req_out.write("package-with-extras[extra1,extra2]")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: in the future, use the pathlib interface of the tmp_path fixture.

Suggested change
with open(req_in, "w") as req_out:
req_out.write("package-with-extras[extra1,extra2]")
req_in.write_text("package-with-extras[extra1,extra2]", encoding="utf-8")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint!

@webknjaz webknjaz added this pull request to the merge queue Nov 1, 2023
Merged via the queue into jazzband:main with commit 3f8108c Nov 1, 2023
36 checks passed
@chrysle chrysle deleted the requirements-header-filter-out-origin-ireqs branch November 6, 2023 15:25
@lociii
Copy link

lociii commented Nov 14, 2023

@atugushev When do you expect a new release of pip-tools that includes this compatibility fix?
There are situations (e.g. we're using renovate with pip-tools) where you cannot downgrade pip and run into this issue.

@jonesbusy
Copy link

There are situations (e.g. we're using renovate with pip-tools) where you cannot downgrade pip and run into this issue.

Same situation here.

Solution I found is to rollback pip3 directly on renovate container (if you are using self hosted)

install-tool python 3.10.13
pip3 install --upgrade pip==23.2.1

@atugushev atugushev added this to the 7.4.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working writer Related to results output writer component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIXME] Nightly CI failures (against pip latest) latest pip (23.3) causes dependency oddity
6 participants