Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade log level for configuration defaults message #1894

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Jun 29, 2023

Resolves #1863 (comment)

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@webknjaz
Copy link
Member

I think there's a similar log message in sync.py.

@webknjaz
Copy link
Member

As for the failing PyPy, I saw it being temporarily disabled in the attrs' CI today, we should probably do the same.

@@ -147,7 +147,7 @@ def cli(
sys.exit(2)

if config:
log.info(f"Using pip-tools configuration defaults found in '{config !s}'.")
log.debug(f"Using pip-tools configuration defaults found in '{config !s}'.")
Copy link
Member Author

@atugushev atugushev Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: It looks like there is no integration test for the config option. See the warning:

image

Copy link
Member Author

@atugushev atugushev Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 3925b41

@atugushev
Copy link
Member Author

As for the failing PyPy, I saw it being temporarily disabled in the attrs' CI today, we should probably do the same.

@webknjaz disabled pypy and updated check job.

@atugushev atugushev added this to the 6.14.0 milestone Jun 29, 2023
@webknjaz webknjaz enabled auto-merge June 29, 2023 21:03
@webknjaz
Copy link
Member

Instead of dropping the dependency, just add it to allowed skips or even allowed failures. It'd be a one-liner instead of coordinated changes in several places..

@webknjaz
Copy link
Member

Also, it's best to make it a separate PR so it's easy to revert with a single click.

@atugushev
Copy link
Member Author

Instead of dropping the dependency, just add it to allowed skips or even allowed failures. It'd be a one-liner instead of coordinated changes in several places..

@webknjaz could you please provide an example or even better push the requested change?

@webknjaz
Copy link
Member

Here you go #1895

@atugushev atugushev disabled auto-merge July 1, 2023 06:45
@atugushev atugushev enabled auto-merge (squash) July 1, 2023 06:45
@atugushev atugushev disabled auto-merge July 1, 2023 06:45
@atugushev atugushev merged commit e14c4cd into jazzband:main Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants