-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade log level for configuration defaults message #1894
Conversation
I think there's a similar log message in |
As for the failing PyPy, I saw it being temporarily disabled in the attrs' CI today, we should probably do the same. |
@@ -147,7 +147,7 @@ def cli( | |||
sys.exit(2) | |||
|
|||
if config: | |||
log.info(f"Using pip-tools configuration defaults found in '{config !s}'.") | |||
log.debug(f"Using pip-tools configuration defaults found in '{config !s}'.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: It looks like there is no integration test for the config option. See the warning:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 3925b41
@webknjaz disabled pypy and updated |
Instead of dropping the dependency, just add it to allowed skips or even allowed failures. It'd be a one-liner instead of coordinated changes in several places.. |
Also, it's best to make it a separate PR so it's easy to revert with a single click. |
@webknjaz could you please provide an example or even better push the requested change? |
Here you go #1895 |
6845fb9
to
6407a82
Compare
6407a82
to
e625695
Compare
Resolves #1863 (comment)
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.