Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out the user provided unsafe packages #1766

Merged
merged 9 commits into from
Dec 11, 2022
Merged

Filter out the user provided unsafe packages #1766

merged 9 commits into from
Dec 11, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Dec 11, 2022 •
edited by atugushev
Loading

Closes #1756

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the bug Something is not working label Dec 11, 2022
@atugushev atugushev added this to the 6.12.0 milestone Dec 11, 2022
@q0w
Copy link
Contributor Author

q0w commented Dec 11, 2022

Does unsafe_requirements in writer._iter_lines provide None as default value only for tests? Because reolver.unsafe_requirements is an empty set by default.

@atugushev
Copy link
Member

Does unsafe_requirements in writer._iter_lines provide None as default value only for tests?

It looks like it does.

atugushev
atugushev approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@q0w
Copy link
Contributor Author

q0w commented Dec 11, 2022

Should I refactor unsafe_requirements and unsafe_packages without None in _iter_lines?

@atugushev
Copy link
Member

Should I refactor unsafe_requirements and unsafe_packages without None in _iter_lines?

Feel free to 👍🏻

atugushev
atugushev reviewed Dec 11, 2022
View reviewed changes
tests/test_writer.py Outdated Show resolved Hide resolved
@atugushev atugushev enabled auto-merge (squash) December 11, 2022 18:36
auto-merge was automatically disabled December 11, 2022 18:37

Head branch was pushed to by a user without write access

@q0w
Copy link
Contributor Author

q0w commented Dec 11, 2022

@atugushev could you enable auto-merge again, i pushed again

@atugushev atugushev enabled auto-merge (squash) December 11, 2022 18:41
@atugushev atugushev merged commit ef88dfc into jazzband:main Dec 11, 2022
@atugushev
Copy link
Member

Thanks @q0w for fixing this!

@q0w q0w deleted the unsafe-package branch December 12, 2022 06:58
@VagueAndroid VagueAndroid mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug Something is not working
Projects
None yet
Milestone
6.12.0
Development

Successfully merging this pull request may close these issues.

unsafe-package is not overriding the default list of packages
3 participants
@q0w @atugushev @ssbarnea