Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor doc edits #1445

Merged
merged 4 commits into from
Oct 13, 2021
Merged

Minor doc edits #1445

merged 4 commits into from
Oct 13, 2021

Conversation

ssiano
Copy link
Contributor

@ssiano ssiano commented Jul 2, 2021 •
edited by atugushev
Loading

Made the "Run it with" paragraphs for pip-compile and pip-sync
consistent.

Removed the extraneous "Run it with" paragraph for pip-sync.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@ssiano
Minor doc edits
766c09b 
Made the "Run it with" paragraphs for pip-compile and pip-sync
consistent.

Removed the extraneous "Run it with" paragraph for pip-sync.
@ssiano
Copy link
Contributor Author

ssiano commented Jul 2, 2021

The Label should be docs and the Milestone should be the next release (6.2.1 or 6.3.0).

@webknjaz webknjaz added the docs Documentation related label Jul 5, 2021
atugushev
atugushev reviewed Oct 12, 2021
View reviewed changes
README.rst Show resolved Hide resolved
atugushev
atugushev approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev merged commit eb9162f into jazzband:master Oct 13, 2021
@atugushev atugushev added this to the 6.5.0 milestone Oct 13, 2021
@atugushev
Copy link
Member

Thanks @ssiano 🙏🏻

@ssiano ssiano deleted the minor-doc-edit-01 branch October 13, 2021 19:47
@atugushev atugushev modified the milestones: 6.5.0, 6.4.1 Oct 16, 2021
@atugushev atugushev modified the milestones: 6.4.1, 6.5.0 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
docs Documentation related
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ssiano @atugushev @webknjaz