-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare pep517 dependency #1353
Declare pep517 dependency #1353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 33 33
Lines 2915 2914 -1
Branches 308 308
==========================================
- Hits 2905 2904 -1
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that makes sense, pep517
would declare the (transitive) dependency on importlib_metadata
for Python < 3.8.
And a bit less impact if pip
moves this vendored part (not that we are resilient to pip
internal changes at all, but that's one thing less :) )
👍
Thanks @webknjaz, @vphilippon and @astrojuanlu 🙏🏼 |
Fixes #1352
Changelog-friendly one-liner: Declare pep517 dependency
Contributor checklist