Consider specifiers for equality operator to pin a dependency in make_install_requirement #1323
Conversation
|
Solved the tox auth issue, will fix the issues on my end and understand what happens with the failing test cases |
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 33 33
Lines 2928 2949 +21
Branches 318 322 +4
=======================================
+ Hits 2917 2938 +21
Misses 5 5
Partials 6 6
Continue to review full report at Codecov.
|
|
Feedback welcome, squash is ready locally (removed the pytest network marker that's not required by my test anymore) Cheers |
make_install_requirement - Changed function signature to take ireq directly rather than passing its members one by one - Changed type hint for version as I was getting a pip Version rather than a string, maybe there are some parts of the code calling with string though - Can confirm it generates a pinned torch with === in my use case as expected
…t from a specifier version as it made tests fail
- Use case example where torch has multiple pin sources
There was a problem hiding this comment.
LGTM 👍🏼 Thanks, @IceTDrinker, for your patience and great work!
Do you need a squashed commit for all this ? |
I'll use the "Squash and merge" button, no worries 👍🏼 |
|
Thanks for the reviews Cheers |
|
pip-tools |
Resolves #1114
Haven't written the test yet, as I would like to know if the spirit of the change suits the authors first
Tried to run
tox -e checkqaas proposed in contribution guidelines but had a failure with github authmembers one by one
a string, maybe there are some parts of the code calling with string though
expected
Changelog-friendly one-liner: Prefer === over == when generating requirements.txt if a dependency was pinned with ===
Contributor checklist