-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop pip-20.0 support #1191
Drop pip-20.0 support #1191
Conversation
d3715fd
to
0bfc6df
Compare
0bfc6df
to
ab4bc1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! One question for now, and two for the future.
now:
- Should we remove
BAR_TYPES
from_compat/{pip_compat,__init__}.py
and import it directly inpypi.py
?
future:
- Do you think it would be worth the trouble to template some of these files, for more automated pip-version updates? Specifically:
.appveyor.yml
,ci.yml
,.travis.yml
,setup.cfg
,tox.ini
- Do we have special reasons to stick with
setup.{cfg,py}
for now, rather than moving topyproject.toml
?
Yeah, thanks for noticing!
Would be nice to automate this.
I'd prefer to stick to |
Co-Authored-By: Andy Kluger <[email protected]>
Thank you @AndydeCleyre for reviewing this! Much appreciated! |
Due to
pip-tools
' policy to support only the last two minor pip versions, it's time to drop thepip-20.0
.pip >= 20.1
insetup.py
20.0
compatible code20.0
from CIREADME
Changelog-friendly one-liner: Drop
pip-20.0
support.Contributor checklist