-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local repository needs to notify proxied repo of ireq copying #1159
Local repository needs to notify proxied repo of ireq copying #1159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 36 36
Lines 2802 2836 +34
Branches 331 332 +1
=======================================
+ Hits 2788 2822 +34
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
Let me know if you think more of an integration test is worthwhile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Could we have an integration test for this regression?
Otherwise, the proxied repository loses track of what dependencies the copy has. The local repo is used to prefer versions from an existing requirements file.
6e8dd89
to
1c65e55
Compare
@atugushev 👍 Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests! I would use make_package
fixture though instead of using existing wheels (to isolate tests), but we could do it in following up PR.
Otherwise, the proxied repository loses track of what dependencies
the copy has. The local repo is used to prefer versions from an
existing requirements file.
Fixes #1154.
Fixes #1155.
Changelog-friendly one-liner: Fixed copying of dependencies when requirements are combined and there is an existing requirements file.
Contributor checklist