Add CI workflow for GitHub Actions #1012

atugushev · 2019-11-27T19:11:56Z

No description provided.

codecov · 2019-11-27T19:21:43Z

Codecov Report

Merging #1012 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          37       37           
  Lines        2675     2680    +5     
  Branches      322      322           
=======================================
+ Hits         2661     2666    +5     
  Misses          8        8           
  Partials        6        6

Impacted Files	Coverage Δ
tests/conftest.py	`100.00% <100.00%> (ø)`
tests/utils.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce3da73...1a45ee3. Read the comment docs.

atugushev · 2019-12-28T15:31:43Z

Tracking issue for tokenless codecov reports: https://community.codecov.io/t/whitelist-github-action-servers-to-upload-without-a-token/491/5

atugushev · 2020-05-03T05:45:56Z

Hey @webknjaz. Thank you so much for such huge feedback! Much appreciated! ❤️ I've resolved all the discussions (I hope, feel free to unresolve otherwise) and I'm ready for another round of review! 🚀

.github/workflows/ci.yml

webknjaz

LGTM overall

codingjoe

Looks good. I am not sure I need tox in a GitHub actions world, but that is certainly a question of preference.

What the only point I'd stress on, would be to merge both workflows. Both have the same running condition and only one job. IMHO it should be one workflow with two or more jobs, preferable a dependent one. A workflow can be as big as this: https://github.com/codingjoe/django/blob/30962/flake8/.github/workflows/ci.yml

.github/workflows/ci.yml

.github/workflows/qa.yml

webknjaz · 2020-05-04T08:14:18Z

Looks good. I am not sure I need tox in a GitHub actions world, but that is certainly a question of preference.

It's needed with any CI because it works like a glue between different platforms, plus it allows running tests locally exactly the same way. It's a well-established practice to use it like this.

webknjaz · 2020-05-04T08:34:22Z

@atugushev maybe on the next iteration we could make the CI actually test the dists too, not just source. And add macOS into the matrix. But right now it seems ready to go. Done is better than perfect.

atugushev · 2020-05-04T09:19:04Z

@webknjaz

maybe on the next iteration we could make the CI actually test the dists too, not just source. And add macOS into the matrix. But right now it seems ready to go. Done is better than perfect.

What do you mean by "test the dists"?

webknjaz · 2020-05-04T10:02:31Z

What do you mean by "test the dists"?

When you run tox, it works with the source in the project dir and even creates some temporary dists. But they are not what you're going to publish to PyPI hence you test not exactly the same as users will get. Also, you may be testing not what's installed for various reasons.
Better way would be to divide this process into stages:

  (1) build dists -> (2) test dists from [1] -> (3) upload *exactly* those dists from [1] that have been tested

atugushev · 2020-05-04T10:38:46Z

@webknjaz

Good suggestion! There is an issue #1134 to track.

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

atugushev · 2020-05-04T16:55:38Z

@webknjaz

I've added MacOS to the matrix.

atugushev · 2020-05-04T17:15:53Z

pypy test jobs are so slow 😞 By the way pip doesn't run tests on pypy, see pypa/pip#7279 (comment). It's tempting to turn them off...

webknjaz · 2020-05-04T19:20:02Z

You could add a condition to only run them on cron and push, for example

webknjaz · 2020-05-04T20:35:19Z

.github/workflows/cron.yml

@@ -1,28 +1,73 @@
-name: cron
+name: Cron


Oh, I didn't think you'd copy all the workflow into another file. I meant we could inject a small if-clause on the job level to filter out things.

Could you post a suggestion?

Something like this should do https://github.com/jazzband/pip-tools/pull/1012/files#r419714725

I'm okay with the copy approach for a while. As soon as GitHub provides an opportunity to make matrix conditionals at a job level we'll refactor it.

Fair enough.

Well, there is a crazy way to implement this: https://help.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#fromjson 🤪

webknjaz · 2020-05-04T20:40:53Z

.github/workflows/ci.yml

+
+jobs:
+  test:
+    name: ${{ matrix.os }} / ${{ matrix.python-version }} / ${{ matrix.pip-version }}


Suggested change

name: ${{ matrix.os }} / ${{ matrix.python-version }} / ${{ matrix.pip-version }}

name: ${{ matrix.os }} / ${{ matrix.python-version }} / ${{ matrix.pip-version }}

if: >-

!startsWith(matrix.python-version, 'pypy') ||

github.event_name != 'pull_request'

Hm... In that case test job is not run.

Why? It should only exclude matching jobs.

I may have made a mistake in the condition, though.

No, it looks correct

That's because you have to apply my suggestion exactly like it's submitted. But you added a leading ! there w/o quoting. This works w/o quoting only if you wrap the whole value with quotes or use a multiline form as I originally suggested.

It's not a context access problem but a YAML parsing one.

Ah, I see. Maybe you're right but that post is old, have you checked if it works with the proper syntax?

Nope, doesn't work.

AndydeCleyre

You and @webknjaz are thoroughly ironing this out. 🙌 👍

.github/workflows/ci.yml

webknjaz · 2020-05-06T08:38:19Z

@codingjoe do you still want to block this?

atugushev · 2020-05-15T14:42:24Z

Seems like it's ready to go! 🚀

atugushev · 2020-05-15T15:15:09Z

I'm so happy we've finally done this. Huge thanks to the reviewers! ❤️

Use `set-output` instead of `set-env`, since it is removed from GHA. See https://github.blog/changelog/2020-11-09-github-actions-removing-set-env-and-add-path-commands-on-november-16/ Addresses jazzband/pip-tools#1012 (comment)

atugushev force-pushed the gh-actions-ci branch 2 times, most recently from 0ae3a35 to cc800ac Compare November 27, 2019 19:21

atugushev force-pushed the gh-actions-ci branch 9 times, most recently from f75bd55 to 56de8bf Compare November 28, 2019 10:05

atugushev force-pushed the gh-actions-ci branch 12 times, most recently from 0c5958d to b743655 Compare February 1, 2020 03:07

atugushev force-pushed the gh-actions-ci branch 4 times, most recently from 7309dcd to 294e31d Compare March 5, 2020 09:22

atugushev closed this Mar 6, 2020

Comment out the pypy exclusion from the matrix

8d39f96

webknjaz reviewed May 3, 2020

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

webknjaz approved these changes May 3, 2020

View reviewed changes

codingjoe requested changes May 4, 2020

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/qa.yml Show resolved Hide resolved

auvipy approved these changes May 4, 2020

View reviewed changes

atugushev mentioned this pull request May 4, 2020

Test the dists #1134

Open

Address review comments

790872f

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

Run pypy test jobs in cron workflow

d2d946a

webknjaz reviewed May 4, 2020

View reviewed changes

webknjaz requested a review from codingjoe May 4, 2020 20:56

AndydeCleyre approved these changes May 6, 2020

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.github/workflows/ci.yml Outdated Show resolved Hide resolved

codingjoe approved these changes May 15, 2020

View reviewed changes

Merge branch 'master' into gh-actions-ci

1a45ee3

atugushev merged commit b1d7369 into jazzband:master May 15, 2020

atugushev deleted the gh-actions-ci branch May 15, 2020 15:14

atugushev mentioned this pull request Dec 1, 2020

Fix GitHub actions example pre-commit/pre-commit.com#432

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CI workflow for GitHub Actions #1012

Add CI workflow for GitHub Actions #1012

atugushev commented Nov 27, 2019

codecov bot commented Nov 27, 2019 •

edited

Loading

atugushev commented Dec 28, 2019

atugushev commented May 3, 2020 •

edited

Loading

webknjaz left a comment

codingjoe left a comment

webknjaz commented May 4, 2020

webknjaz commented May 4, 2020

atugushev commented May 4, 2020 •

edited

Loading

webknjaz commented May 4, 2020

atugushev commented May 4, 2020

atugushev commented May 4, 2020

atugushev commented May 4, 2020

webknjaz commented May 4, 2020

webknjaz May 4, 2020

atugushev May 4, 2020

webknjaz May 4, 2020

atugushev May 5, 2020

webknjaz May 5, 2020

webknjaz May 5, 2020

atugushev May 6, 2020

webknjaz May 4, 2020 •

edited

Loading

atugushev May 4, 2020

webknjaz May 4, 2020

webknjaz May 4, 2020

webknjaz May 4, 2020

webknjaz May 4, 2020 •

edited

Loading

webknjaz May 4, 2020

webknjaz May 4, 2020

atugushev May 4, 2020

webknjaz May 4, 2020

AndydeCleyre left a comment

webknjaz commented May 6, 2020

atugushev commented May 15, 2020

atugushev commented May 15, 2020

Add CI workflow for GitHub Actions #1012

Add CI workflow for GitHub Actions #1012

Conversation

atugushev commented Nov 27, 2019

codecov bot commented Nov 27, 2019 • edited Loading

Codecov Report

atugushev commented Dec 28, 2019

atugushev commented May 3, 2020 • edited Loading

webknjaz left a comment

Choose a reason for hiding this comment

codingjoe left a comment

Choose a reason for hiding this comment

webknjaz commented May 4, 2020

webknjaz commented May 4, 2020

atugushev commented May 4, 2020 • edited Loading

webknjaz commented May 4, 2020

atugushev commented May 4, 2020

atugushev commented May 4, 2020

atugushev commented May 4, 2020

webknjaz commented May 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webknjaz May 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webknjaz May 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndydeCleyre left a comment

Choose a reason for hiding this comment

webknjaz commented May 6, 2020

atugushev commented May 15, 2020

atugushev commented May 15, 2020

codecov bot commented Nov 27, 2019 •

edited

Loading

atugushev commented May 3, 2020 •

edited

Loading

atugushev commented May 4, 2020 •

edited

Loading

webknjaz May 4, 2020 •

edited

Loading

webknjaz May 4, 2020 •

edited

Loading