long is also a valid type
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahhh drat I forgot they removed the long type in python 3. Is there a way to only do this check in python 2.7? |
|
There's a couple options you could do:
Option 2 might be preferred because it seems excessive to pull in a whole dependency just for a simple check |
|
Errr, weird. The six check didn't seem to work? |
| # Python 3.x has no long type | ||
| JSON_compliant_types = (float, int, Decimal) | ||
| else: | ||
| JSON_compliant_types = (float, int, Decimal, long) |
There was a problem hiding this comment.
Try changing this to:
JSON_compliant_types = (float, int, Decimal, long) # noqaflake8 is throwing the error about long not existing in Python 3. # noqa tells flake8 to not report errors on this line. Sorta hacky, but it should work for now
| # Python 3.x has no long type | ||
| JSON_compliant_types = (float, int, Decimal) | ||
| else: | ||
| JSON_compliant_types = (float, int, Decimal, long) # noqa |
There was a problem hiding this comment.
There need to be two spaces before the #
|
kk! |
|
Thanks for your contribution @bennlich ! 💃 |
|
I just published 1.2.1 that includes your changes. Thanks again! |
|
Awesome! |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Aug 9, 2015
1.2.2 (2015-07-13) ------------------ - Fix tests by including test file into build - jazzband/geojson#61 - Build universal wheels - https://packaging.python.org/en/latest/distributing.html#universal-wheels 1.2.1 (2015-06-25) ------------------ - Encode long types correctly with Python 2.x - jazzband/geojson#57 1.2.0 (2015-06-19) ------------------ - Utility function to validate GeoJSON objects - jazzband/geojson#56 1.1.0 (2015-06-08) ------------------ - Stop outputting invalid GeoJSON value id=null on Features - jazzband/geojson#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.