Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default lat/lon precision to base Geometry class #131

Merged
merged 10 commits into from
Jul 18, 2019
Merged

Conversation

rayrrr
Copy link
Member

@rayrrr rayrrr commented Jul 15, 2019

In response to #84:

  • Add a precision parameter to the Geometry base class (accessible on all GeoJSON Type subclasses)
  • Set default precision to 6 decimal places (~11.1cm)
  • Update unit tests to confirm rounding feature
  • Update examples in docs to explain rounding feature

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #131 into master will decrease coverage by 2.89%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #131     +/-   ##
=========================================
- Coverage   95.36%   92.46%   -2.9%     
=========================================
  Files          10       10             
  Lines         345      345             
  Branches       69       69             
=========================================
- Hits          329      319     -10     
- Misses          9       16      +7     
- Partials        7       10      +3
Impacted Files Coverage Δ
geojson/geometry.py 97.64% <100%> (-2.36%) ⬇️
geojson/mapping.py 80.95% <0%> (-9.53%) ⬇️
geojson/utils.py 84.76% <0%> (-3.81%) ⬇️
geojson/base.py 94.64% <0%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1b814...7dcbcdd. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          10       10           
  Lines         345      345           
  Branches       69       69           
=======================================
  Hits          329      329           
  Misses          9        9           
  Partials        7        7
Impacted Files Coverage Δ
geojson/geometry.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1b814...79016f0. Read the comment docs.

@rayrrr rayrrr merged commit d3e7bcb into master Jul 18, 2019
@rayrrr rayrrr deleted the default-precision branch July 18, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants