-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Django 4.2 #711
Conversation
https://docs.djangoproject.com/en/4.2/releases/4.2/#miscellaneous
It looks like DRF 3.13 is not compatible with Django 4.2. |
@Andrew-Chen-Wang It looks like only DRF 3.13 is incompatible with Django 4.2. The way the matrix is currently set up in GitHub Actions and djangorestframework-simplejwt/.github/workflows/test.yml Lines 17 to 20 in aa077a4
djangorestframework-simplejwt/tox.ini Lines 16 to 26 in aa077a4
It is possible to be more specific/explicit using But I'm not sure what your preference here is. |
@johnthagen An option would be to configure the GH Actions test workflow to skip matrix configuration matching a certain criteria with the matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
django-version: ['3.2', '4.0', '4.1', '4.2']
drf-version: ['3.10', '3.11', '3.12', '3.13', '3.14']
exclude:
- django-version: '4.2'
drf-version: '3.13' I haven't tested, but should provide the desired outcome. |
Thanks @dpgraham4401! That was exactly what was needed. Implemented in d74835a. |
@Andrew-Chen-Wang this PR is now ready for review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you everyone for helping out. This looks great!
* Add support for Django 4.2 * Exclude DRF 3.13 & Django 4.2 CI combination
Closes #706
Closes #707